Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLUniformsGroups: Fix buffer offset calculation. #28834

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 8, 2024

Fixed #28818.

Description

This PR corrects the offset computation in WebGLUniformsGroups.

@RenaudRohlinger The boundary is not correctly honored in prod right now and I think this should fix it.

@Mugen87 Mugen87 requested a review from RenaudRohlinger July 8, 2024 10:05
@Mugen87 Mugen87 added this to the r167 milestone Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.5 kB (169.2 kB) 683.5 kB (169.2 kB) +25 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.6 kB (111.1 kB) 460.7 kB (111.1 kB) +25 B

@Mugen87 Mugen87 merged commit 5457a9d into mrdoob:dev Jul 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGLRenderer: UBO / Uniform Buffer Object - Vec2 is not binded correctly.
2 participants