Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTKLoader: Add support for AppendedData. #28816

Merged
merged 3 commits into from
Jul 5, 2024
Merged

VTKLoader: Add support for AppendedData. #28816

merged 3 commits into from
Jul 5, 2024

Conversation

Mt-Youya
Copy link
Contributor

@Mt-Youya Mt-Youya commented Jul 5, 2024

Related issue: #28815

Description
Add "AppendedData " format support.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 5, 2024

Do you mind sharing a VTK asset for testing? The one from your issue points to a 404 page:

https://github.com/Mt-Youya/vanilla-oral/blob/main/public/assets/models/user-appendedData.vtp

@Mt-Youya
Copy link
Contributor Author

Mt-Youya commented Jul 5, 2024

Oh! Sorry! I forget set public. It works now!
assets here
Here all assets for testing!
And I testing in editor

@Mugen87 Mugen87 added this to the r167 milestone Jul 5, 2024
More clean up.
@Mugen87 Mugen87 changed the title fix: VTKLoader.js parse "AppendedData" format VTKLoader: Add support for AppendedData. Jul 5, 2024
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The existing assets still work and user-appendedData.vtk from your test repo works now.

@Mugen87 Mugen87 merged commit 2722761 into mrdoob:dev Jul 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants