Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Improve the slider in the wide gamut example #28810

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

WestLangley
Copy link
Collaborator

Improved the look of the slider.

Also fixed bugs in the slider when resizing the window.

@WestLangley WestLangley added this to the r167 milestone Jul 5, 2024
@WestLangley
Copy link
Collaborator Author

The updated screenshot is not correct...

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 5, 2024

The E2E testing for this particular example should be improved by updating https://github.com/mrdoob/three.js/blob/dev/test/e2e/clean-page.js. This script ensure to remove all HTML which overlays the renderer's canvas so the testing can focus on the renderer output.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 5, 2024

It seems adding the slider and label class to the following line should be sufficient.

style.innerHTML = '#info, button, input, body > div.lil-gui, body > div.lbl { display: none !important; }';

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 5, 2024

webgl_test_wide_gamut

The above is the screenshot generated on my system so it's not a general issue.

Did you do a npm i before making the screenshot? Maybe you are using an outdated dependencies.

@WestLangley
Copy link
Collaborator Author

I tried updating, but no luck... (I am on a mac, using homebrew.)

It appears the animation loop is rendering before the textures load.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 5, 2024

Then let me update the screenshot after the merge so it's not blocking the PR.

@WestLangley
Copy link
Collaborator Author

OK. I reverted the screenshot update.

@Mugen87 Mugen87 merged commit 28d1e18 into mrdoob:dev Jul 6, 2024
18 of 20 checks passed
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 6, 2024

6b23527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants