-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaders: Improve Packing #28789
Shaders: Improve Packing #28789
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do you mind reverting the changes to three.module.js
for merging?
7ab47b3
to
c0fcb62
Compare
Any reason why this wasnt included in 167 milestone? It took me by suprise that my implementation of depth picking stoped working properly. |
Not sure what you mean since the changes are part of the engine since |
@lmicola Do you mean in the change log? |
Perhaps he is referring to r167 in the migration guide. |
The /ping @Mugen87 |
Fixed #28692.
This PR implements the improvements to packing suggested by @leonbloy in #28692.