Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: Improve Packing #28789

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Shaders: Improve Packing #28789

merged 1 commit into from
Jul 3, 2024

Conversation

WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Jul 3, 2024

Fixed #28692.

This PR implements the improvements to packing suggested by @leonbloy in #28692.

Copy link

github-actions bot commented Jul 3, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
682.2 kB (169 kB) 683.4 kB (169.2 kB) +1.26 kB

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
459.4 kB (110.9 kB) 460.6 kB (111.1 kB) +1.2 kB

@Mugen87 Mugen87 added this to the r167 milestone Jul 3, 2024
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you mind reverting the changes to three.module.js for merging?

@Mugen87 Mugen87 merged commit a38bbdd into mrdoob:dev Jul 3, 2024
12 checks passed
@WestLangley WestLangley deleted the dev-pack_depth_2 branch July 3, 2024 17:45
@lmicola
Copy link

lmicola commented Oct 9, 2024

Any reason why this wasnt included in 167 milestone? It took me by suprise that my implementation of depth picking stoped working properly.

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 9, 2024

Not sure what you mean since the changes are part of the engine since r167.

@mrdoob
Copy link
Owner

mrdoob commented Oct 9, 2024

@lmicola Do you mean in the change log?

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 9, 2024

It should be there:

image

@WestLangley
Copy link
Collaborator Author

Perhaps he is referring to r167 in the migration guide.

@lmicola
Copy link

lmicola commented Oct 16, 2024

I apologize. I thought that this PR was not included in change log. I think mention about RGBADepthPacking color output change in migration guide would be helpfull. I wonder if it is possible to make depthBuffer and reverseDepthBuffer color output uniform.
depth
reverseDepth

@WestLangley
Copy link
Collaborator Author

The RGBADepthPacking API has not changed, only the implementation. I am inclined to think it is not appropriate to include it in the r167 migration guide.

/ping @Mugen87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packDepthToRG seems broken
4 participants