Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add FilmNode. #28770

Merged
merged 9 commits into from
Jun 30, 2024
Merged

Node: Add FilmNode. #28770

merged 9 commits into from
Jun 30, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 30, 2024

Related issue: -

Description

This PR adds FilmNode and migrates misc_controls_fly to WebGPURenderer. Since misc_controls_fly is no webgl_* example and uses post processing, it's better to update it than creating a new demo.

Copy link

github-actions bot commented Jun 30, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
682.2 kB (169 kB) 682.2 kB (169 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
459.4 kB (110.9 kB) 459.4 kB (110.9 kB) +0 B

@Mugen87 Mugen87 added this to the r167 milestone Jun 30, 2024
@sunag
Copy link
Collaborator

sunag commented Jun 30, 2024

@Mugen87 I made some changes:

    1. intensityNode = null - In this case there will only be the calculation if the user adds the optional parameter.
    1. I removed the grayscale, I think that with TSL this becomes unnecessary since the user will be able to make connections with other nodes, for example: scenePassColor.film().saturation( 0 )
    1. nodeProxy - will apply nodeObject() to all parameters

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 30, 2024

Agreed! It makes sense to rethink the API since the material handling is different compared to the previous approach. Besides, I'm all-in for focusing the effects on the most important features. The grayscale option was always a bit of a gimmick.

@sunag sunag merged commit af4898d into mrdoob:dev Jun 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants