Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathNode: Add rand(). #28765

Merged
merged 1 commit into from
Jun 30, 2024
Merged

MathNode: Add rand(). #28765

merged 1 commit into from
Jun 30, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 30, 2024

Related issue: -

Description

This ports the rand() GLSL helper function from commons.glsl to TSL and adds it to MathNode.

rand() is used multiple times in the addons e.g. in FilmPass that I want to port next.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
682.2 kB (169 kB) 682.2 kB (169 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
459.4 kB (110.9 kB) 459.4 kB (110.9 kB) +0 B

@sunag sunag merged commit 77aefe8 into mrdoob:dev Jun 30, 2024
12 checks passed
@sunag sunag added this to the r167 milestone Jun 30, 2024
@sunag
Copy link
Collaborator

sunag commented Jun 30, 2024

/cc @brunosimon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants