Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimplifyModifier: Fix missing import #28763

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

yfunk
Copy link
Contributor

@yfunk yfunk commented Jun 29, 2024

Related issue: -

Description

SimplifyModifier currently tries to use THREE.Color without actually importing the library as THREE. This causes a ReferenceError to be thrown if the geometry has a color attribute (live example).

This PR resolves this issue by updating the existing import to include Color.

@Mugen87 Mugen87 added this to the r167 milestone Jun 29, 2024
@Mugen87 Mugen87 merged commit 3b935a4 into mrdoob:dev Jun 29, 2024
11 checks passed
mrdoob pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants