SSAOPass: Remove one copy pass. #28744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
Similar to
SAOPassthe AO is now blended on top of the existing read buffer which makes one copy pass redundant and thus improves performance.The alternative would be to implement a composite/blend shader that blends
readBuffer.texturewith the AO into the write buffer. However, always reading fromreadBufferand writing intowriteBufferhas performance issues since copies are required like in the original version ofSSAOPass. For certain FX passes, it makes sense if they blend/write their result on top of the "source" data without unnecessary copy or swap operations.