WebGPURenderer: Update attribute only when needed #28701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consequently the example I will also need to fix the fact adding |
|
Added a fix in |
sunag
reviewed
Jun 19, 2024
| @@ -85,6 +93,22 @@ class InstanceNode extends Node { | |||
|
|
|||
| } | |||
|
|
|||
| update( /*frame*/ ) { | |||
|
|
|||
| if ( this.buffer !== null && this.instanceMesh.instanceMatrix.version !== this.buffer.version ) { | |||
There was a problem hiding this comment.
This check necessary? this.buffer !== null update() should be called after setup.
There was a problem hiding this comment.
Indeed! Updated the PR accordingly 👍
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28697
Description
This PR addresses an issue where WebGPURenderer was updating all attributes in every render frame, regardless of their state. With this fix, attributes are now updated only if
attribute.needsUpdatehas been called, enhancing performance. /cc @sunagThis PR fixes the handling of interleavedBuffer management.
InstanceNodewas missing a way to notify the associated buffers if theinstanceMatrixandinstanceColorwere flagged to be updated, I also added a way to transfer the correct version to the corresponding buffers.This contribution is funded by Utsubo