TSL: UniformNode Support Int/Uint #28667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
reviewed
Jun 16, 2024
| ColorUniform, Matrix3Uniform, Matrix4Uniform | ||
| } from '../Uniform.js'; | ||
|
|
||
| class FloatNodeUniform extends FloatUniform { | ||
| class ScalarNodeUniform extends ScalarUniform { |
There was a problem hiding this comment.
Maybe NumberNodeUniform? or 'NumericNode...'
Scalar is interesting if we are going to use boolean as well.
There was a problem hiding this comment.
I renamed it to NumberNodeUniform, seems more familiar than numeric scalar or scalar
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently only float uniforms were supported. This PR adds int/uint formats.
Example usage:
This contribution is funded by Utsubo