Example: Don't accumulate tiny translations in games_fps.html #28662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #28660
Description
The cause is that the example blindly pushes
playerCollider
away from the intersectionnormal
bydepth
amount in every frame, so say when player is idling on ramp, the tiny offset will eventually add up >octree_threshold, then octree considers that theplayerCollider
is not intersecting with the ramp.This PR fixed that by translating the
playerCollider
only ifintersection's depth >= octree_threshold