Editor: Disposes object's helper when removing helper #28614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Jun 10, 2024
| @@ -469,6 +469,7 @@ Editor.prototype = { | |||
|
|
|||
| var helper = this.helpers[ object.id ]; | |||
| helper.parent.remove( helper ); | |||
| helper.dispose(); | |||
There was a problem hiding this comment.
Since all helpers have a dispose() method, this call is safe.
Mugen87
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disposes the object's helper when
editor.removeHelper(object), s.t. it won't leak helper's geometry.VertexNormalHelper's geometry size is variant, and it casually holds thousands of f32s for example: