-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLRenderer: Sort objects in clip space. #28571
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
The doc-change broke a bunch of visual tests. I see a lot of |
It's an issue of the E2E environment. We don't know why sometimes WebGL context creation fails. I'll rerun the failed test which is often the best approach to get a successful CI run. |
Original PR #28474 was merged slightly early; here's the changes that the discussion in that PR landed on.
This PR changes the space in which objects are sorted from NDC to clip space, as well as adds
Vector4.setFromMatrixPosition
for convenience.