GLTFLoader: Use ImageBitmapLoader
in for Safari >= 17.
#28560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start using ImageBitmapLoader for Safari >= 17 to fix texture loading in a web worker. Also makes Safari three.js texture loading performance better.
Note
I have only tested this on Safari 17.5 as I don't have older one available. Partial support for CreateImageBitmap in Safari has been around for a longer time but it would be great if someone could make sure that textures still load fine with GLTFLoader when using Safari 17.0. If not, we can change the version limit to 17.5.
The currently used TextureLoader cannot be used in a web-worker and will fail with an error.