Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "upgrade tween.module.js to 23.1.2" #28554

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Revert "upgrade tween.module.js to 23.1.2" #28554

merged 1 commit into from
Jun 4, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 4, 2024

Reverts #28391

@Mugen87 Mugen87 merged commit 87b07a4 into dev Jun 4, 2024
3 of 4 checks passed
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 4, 2024

It seems 23.1.2 changes the behavior of yoyo() which breaks the current usage in the examples.

@Mugen87 Mugen87 mentioned this pull request Jun 4, 2024
Merged
@Mugen87 Mugen87 added this to the r166 milestone Jun 4, 2024
@Mugen87 Mugen87 deleted the revert-28391-dev-lib branch June 4, 2024 10:01
@mrdoob
Copy link
Owner

mrdoob commented Jun 4, 2024

/ping @trusktr

@linbingquan
Copy link
Contributor

It seems 23.1.2 changes the behavior of yoyo() which breaks the current usage in the examples.

It has been reverted in v23.1.3

link: tweenjs/tween.js#687 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r166
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugen87 @mrdoob @linbingquan