WebGLRenderer: Fix WebXR depth sensing. #28530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
May 30, 2024
Mugen87
changed the title
Mugen87
approved these changes
May 30, 2024
This was referenced May 31, 2024
mrdoob
reviewed
May 31, 2024
| document.body.appendChild( XRButton.createButton( renderer, { 'optionalFeatures': [ 'depth-sensing'] } ) ); | ||
| document.body.appendChild( XRButton.createButton( renderer, { | ||
| 'optionalFeatures': [ 'depth-sensing' ], | ||
| 'depthSensing': { 'usagePreference': [ 'gpu-optimized' ], 'dataFormatPreference': [] } |
There was a problem hiding this comment.
Is 'dataFormatPreference': [] needed?
There was a problem hiding this comment.
It is. We're updating the spec to specify that an empty array means that the value is optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth sensing is broken in the current version of three.js.
This change will restore depth sorting functionality and also removes the extra renderpass of the previous solution.
The samples also didn't add the depthSensing dictionary during session creation. Quest browser wasn't spec compliant so didn't pass this in. That will be fixed in a future version of the spec.
cc @Mugen87