Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raycaster: Return false to avoid propagation #28520

Merged
merged 1 commit into from
May 29, 2024
Merged

Raycaster: Return false to avoid propagation #28520

merged 1 commit into from
May 29, 2024

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented May 29, 2024

Related issue: #27709

Description

As explained in #27709 (comment)

@mrdoob mrdoob added this to the r165 milestone May 29, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
677.8 kB (168 kB) 677.8 kB (168 kB) +12 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
455.8 kB (110.1 kB) 455.8 kB (110.1 kB) +0 B

@mrdoob mrdoob merged commit 70d0eb1 into dev May 29, 2024
12 checks passed
@mrdoob mrdoob deleted the raycaster branch May 29, 2024 04:40
@Methuselah96 Methuselah96 mentioned this pull request May 29, 2024
37 tasks
CodyJasonBennett added a commit to CodyJasonBennett/three.js that referenced this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant