Editor: Alerts if invalid material found when rendering image in REALISTIC #28518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
May 31, 2024
Mugen87
reviewed
Jun 3, 2024
Mugen87
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pathtracer only supports MeshStandardMaterial and MeshPhysicalMaterial, so when rendering image in REALISTIC, editor will popup a blank window if there're invalid materials in scene. This PR alerts users instead for this case.
Also, this PR updated UISelect's keys to use shading name in string,
'realistic', instead of number-but-actually-string1, the code is now easier to reason about