Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Fix Math/Operators fail generate cache with same node #28502

Merged
merged 1 commit into from
May 27, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented May 27, 2024

Description

It was not automatically generating cache if the same node was using more than one argument from the same node, e.g:

const a = vector.normalize();

// The result of normalize is now stored in a variable to avoid redundancy due to it being used more than once.
// Without needs to use 'a.toVar()' for this

const b = a.mul( a );

@sunag sunag marked this pull request as ready for review May 27, 2024 18:09
@sunag sunag added this to the r165 milestone May 27, 2024
@sunag sunag merged commit 23e6810 into mrdoob:dev May 27, 2024
11 checks passed
@sunag sunag deleted the dev-node-utils branch May 27, 2024 18:26
@Methuselah96 Methuselah96 mentioned this pull request May 29, 2024
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant