Editor: Added User Data input in GEOMETRY tab #28489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
May 25, 2024
|
I have noticed one unrelated thing while testing: With English language settings a scroll horizontal bar occurs by default now: 
Shouldn't the default styles ensure the sidebar is wide enough so no scroll bar occurs when using the English setting? |
|
The h scrollbar presents here due to 22px margin-right added to last tab, that margin is used to ensure that the last tab can be fully shown even if sidebar's v scrollbar is triggered: last.tab.fully.shown.mp4 |
|
Even then it would be good to hide it by default. |
|
done. #28491 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #28488
Preview: https://raw.githack.com/ycw/three.js/editor-add-userdata-in-geometry-tab/editor/index.html