Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Added REALISTIC shading support for image rendering #28448

Merged

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 21, 2024

Currently users can render image via PROJECT>IMAGE>RENDER, but it only supports SOLID shading type, this PR added REALISTIC type:

render.with.realistic.shading.mp4

Preview: https://raw.githack.com/ycw/three.js/editor-image-rendering-supports-realistic-shading/editor/index.html

Demo project: (File>Open) project.json

editor/js/Sidebar.Project.Image.js Fixed Show resolved Hide resolved
@ycw ycw force-pushed the editor-image-rendering-supports-realistic-shading branch 2 times, most recently from fa63147 to 25bb5cc Compare May 21, 2024 10:29
@ycw ycw force-pushed the editor-image-rendering-supports-realistic-shading branch from fa6f125 to 0b0fd69 Compare May 21, 2024 11:10
@mrdoob mrdoob added this to the r165 milestone May 21, 2024
@mrdoob mrdoob merged commit 64a25dd into mrdoob:dev May 21, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants