Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLBackground: Make sure buffers are writable before clear. #28446

Merged
merged 1 commit into from
May 21, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 20, 2024

Related issue: #28445

Description

As suggested in #28445 (comment), ensuring a correct WebGL state before the background is rendered is now part of WebGLBackground.render().

@Mugen87 Mugen87 added this to the r165 milestone May 20, 2024
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 20, 2024

@mrxz Looking good?

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
679.1 kB (168.3 kB) 679.1 kB (168.3 kB) +2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.1 kB (110.3 kB) 457.1 kB (110.3 kB) -1 B

@mrxz
Copy link
Contributor

mrxz commented May 20, 2024

@Mugen87 Without testing the code, change looks good. Ultimately I think your suggestion of moving it into WebGLRenderer.clear() might be better, see #28445 (comment).

@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 21, 2024

see #28445 (comment)

@Mugen87 Mugen87 merged commit d34df93 into mrdoob:dev May 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants