New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Fixed unhandled material array when exporting JSON #28431

Merged

mrdoob merged 1 commit into mrdoob:dev from ycw:editor-export-json-honors-materialslot

May 20, 2024

Contributor

ycw commented May 19, 2024

This PR fixed an issue about EXPORT JSON in MATERIAL tab, which doesn't honor material array, it will throw if doing so:

To reproduce:

Drops https://github.com/mrdoob/three.js/tree/dev/examples/models/collada/elf in editor
Opens console
Navigates to MATERIAL tab, presses EXPORT JSON.


          export json honors material array

ca4c92f

mrdoob added this to the r165 milestone

mrdoob merged commit 312b7ee into mrdoob:dev

10 of 11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet