Editor: Fixed wrong aspect ratio for non default cameras on window resize #28425
Conversation
|
|
||
| const camera = editor.cameras[ uuid ]; | ||
|
|
||
| if ( camera.isPerspectiveCamera ) { |
There was a problem hiding this comment.
Shouldn't all cameras be resized? The issue still happens with orthographic cameras.
There was a problem hiding this comment.
Correct, this PR only handled the perspective cameras' aspect ratio. To keep consistent with this
three.js/editor/js/Viewport.js
Lines 638 to 642 in aa65ec2
else if ( camera.isOrthographicCamera ) { // TODO } for clarification?
There was a problem hiding this comment.
This check should be removed and orthographic cameras resized like perspective cameras. The aspect needs to be honored in the left and right property otherwise the projection matrix is incorrect.
There was a problem hiding this comment.
I see, thanks for pointing out that, would you mind file a PR or add //TODO for now because ortho camera is not in my todo list :'(
There was a problem hiding this comment.
To make sure that we're on the same page, this is the issue we didn't fix:
orthographic.camera.projection.matrix.not.updated.on.reisze.mp4
The issue: non default cameras' aspect ratio doesn't get updated on resize:
non.default.camera.has.wrong.aspect.mp4
With this PR:
non.default.camera.has.correct.aspect.mp4
Preview: https://raw.githack.com/ycw/three.js/editor-shading-with-correct-aspect-ratio/editor/index.html