Editor: Added appearance submenu #28421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR moves helpers toggling from viewport to View>Appearance>, and users can now toggle helpers by type:
keep.depth.perception.mp4
It's practical:
"SkeletonHelper is always shown infront of everything" is of WONT FIX, meaning that SkeletonHelpers will be always shown even behind walls for example. This PR fixed 'depth perception lost' by offering an option to toggle all
SkeletionHelper.CameraHelpers should be shown only if needed; There can be many cameras on scene(an example is
models/collada/pump/pump.dae), in this case showing all CameraHelpers will hurt editing experience, in particular the CameraHelpers overlapped with the object that users are transforming. This PR fixed that by offering an option to toggle CameraHelpers seperately.Unlike SkeletonHelper, bounding box and transform gizmo are needed to be always shown infront, because that is their sole purpose: spotting the selected object's location and size on the scene, because of that, they aren't included in
View>Appearance>submenu.The togglers(Grid, Helpers) are moved from viewport into menu bar
View>Appearance>, s.t. from now on, users will be taught that it's the single place to show/hide things, currently only on-scene helpers; In the future, the submenu will be included overlays e.g. 'viewport info', and UI items, e.g. 'sidebar'.Thanks.