WebGPURenderer: Revert "Fix SampledTexture not correctly bound (#28289)" #28402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenaudRohlinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28289
Description
This PR reverts #28289, which, after further investigation, appears to have been an incorrect fix. In addition to reverting the changes, this PR adds a patch to prevent the initial error and assist in debugging the original issue as mentioned in this comment: #28392 (comment). /cc @sunag
Good news, the original issue is 100% reproductible without the
backend.isWebGPUBackend === truecondition in the patch in thewebgpu_loader_gltf_transmissionexample in Safari in the WebGLBackend (not Chrome).This contribution is funded by Utsubo