Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurveModifier: Switch to half float. #28377

Merged
merged 1 commit into from
May 15, 2024
Merged

CurveModifier: Switch to half float. #28377

merged 1 commit into from
May 15, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 14, 2024

Related issue: #28375 (comment)

Description

Switching to a half float texture in CurveModifier for better compatibility.

@Mugen87 Mugen87 added this to the r165 milestone May 14, 2024
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 14, 2024

@manthrax Does half float work in your app as well?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 14, 2024

@manthrax
Copy link
Contributor

It looks fine to me on that text example..

I also checked it in my more complex example and didn't see any visual difference, so, LGTM? :D

@Mugen87 Mugen87 merged commit b85a398 into mrdoob:dev May 15, 2024
12 checks passed
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 15, 2024

Thanks for testing!

The change to half float is also a performance improvement since it saves memory and bandwidth (which is especially important for mobile).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants