Editor: Fixed TODO: Bind lexical this #28357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a TODO in ui.three.js about binding this without
.bind()
;this.update
is consumed here:UIPoints2
three.js/editor/js/libs/ui.three.js
Lines 683 to 684 in db0a63d
UIPoints3
three.js/editor/js/libs/ui.three.js
Lines 778 to 780 in db0a63d