Editor: Fixed camera UUID lost when recovering #28337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycw
force-pushed
the
editor-fully-copy-camera
branch
from
7759fc3 to
a564aa9
Compare
Mugen87
reviewed
May 12, 2024
ycw
force-pushed
the
editor-fully-copy-camera
branch
from
91f624b to
12b9bda
Compare
Mugen87
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue: When recovering from IndexedDB, all properties are copied to existing default camera, except for
.uuid, in turn commands, which hold object uuid referencing to the default camera, will fail to undo/redo, because they wont be able to get back the camera by UUID during recovery, for example SetValueCommand'sobjectstate will beundefinedafter recovery.This PR fixed that by copying
.uuidto existing default camera, also updatingeditor.cameras.