Editor: Fixed selected object unselected when recovering #28318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clarify that this PR can only restore selected state if selected object is a scene object. i.e. If users selected default Camera or Scene, there will be nothing auto-selected in outliner after restoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue: The selected scene object in outliner becomes unselected when recovering
To reproduce:
This cause: "Restoring selected object"
editor.selectByUuid()should follow "Restoring the editor"editor.fromJSON(), however,editor.fromJSON()returns a promise which ... isn't be awaited ... , so the order is reversed and failed as expected.This PR fixed that by simply awaiting the
editor.fromJSON().