Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: copyTextureToTexture subframe upload and new API #28315

Merged
merged 2 commits into from
May 8, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Related: #28281

Description

Align WebGPURenderer.copyTextureToTexture API with the WebGLRenderer.

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r165 milestone May 8, 2024
@mrdoob mrdoob requested a review from sunag May 8, 2024 14:04
@sunag sunag merged commit a6fba0f into mrdoob:dev May 8, 2024
7 of 11 checks passed
@sunag
Copy link
Collaborator

sunag commented May 8, 2024

I would propose something similar in copyFramebufferToTexture for WebGLRenderer. We were already ignoring the first parameter position in copyFramebufferToTexture of WebGPURenderer, the current function signature is more similar with this, because most of the time it is not used position parameter, this new sequence of parameters is much better in my option too. I think we can follow the same logic in copyFramebufferToTexture too?

@mrdoob
Copy link
Owner

mrdoob commented May 10, 2024

Sounds good 👍

Methuselah96 added a commit to Methuselah96/three.js that referenced this pull request May 18, 2024
The third argument passed to `copyTextureToTexture` should be a `Box2` or `null`. I believe this is an oversight in mrdoob#28315.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants