Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Added submenu navigation #28311

Merged
merged 3 commits into from
May 7, 2024
Merged

Editor: Added submenu navigation #28311

merged 3 commits into from
May 7, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 7, 2024

Related: #28284

This PR added submenu navigation

submenu+shadow.en.mp4

Preview: https://raw.githack.com/ycw/three.js/editor-submenu/editor/index.html

@mrdoob
Copy link
Owner

mrdoob commented May 7, 2024

Looking good!

@mrdoob
Copy link
Owner

mrdoob commented May 7, 2024

Actually, sorry... Instead of "Geometry" it should be "Mesh" 🙏

@ycw ycw force-pushed the editor-submenu branch from 946f4da to db1b7af Compare May 7, 2024 22:14
@ycw
Copy link
Contributor Author

ycw commented May 7, 2024

done :D

@mrdoob mrdoob merged commit 72d10f8 into mrdoob:dev May 7, 2024
8 of 12 checks passed
@mrdoob
Copy link
Owner

mrdoob commented May 7, 2024

Thanks!

@mrdoob mrdoob added this to the r165 milestone May 7, 2024
@mrdoob
Copy link
Owner

mrdoob commented May 8, 2024

Few more tweaks: 9f81b72 cc9a249 c857c1e cf29a58 3468145 65c4c27 c5ae348 b2e1389

@mrdoob
Copy link
Owner

mrdoob commented May 8, 2024

Screen.Recording.2024-05-07.at.5.37.25.PM.mov

@ycw
Copy link
Contributor Author

ycw commented May 8, 2024

what about

File 
  New
  Example >     <<<<<< put examples here
  Import
  Export >

?

@mrdoob
Copy link
Owner

mrdoob commented May 8, 2024

Good idea!

I think I would then add a couple of UIHorizontalRules.

File 
  New
  ---
  Examples >
  ---
  Import
  Export >

@ycw
Copy link
Contributor Author

ycw commented May 8, 2024

Good choice.

@mrdoob
Copy link
Owner

mrdoob commented May 9, 2024

While looking at this I wanted to see how it would look like if we listed all the formats...

Screenshot 2024-05-08 at 8 29 12 PM

Way too intimidating...

@mrdoob
Copy link
Owner

mrdoob commented May 9, 2024

Just found out about <input>'s accept property: a131775

That way the user can tell what files can be imported.

Before:

Screenshot 2024-05-08 at 8 45 47 PM

After:

Screenshot 2024-05-08 at 8 45 26 PM

@ycw
Copy link
Contributor Author

ycw commented May 9, 2024

Just found out about < input > 's accept property: a131775

Good, and remember that accept list must be in sync with Loader.js #28295 (comment)

@ycw
Copy link
Contributor Author

ycw commented May 9, 2024

what about

File 
  New
  Example >     <<<<<< put examples here
  Import
  Export >

?

Updated to

File
  New Project >       << all examples goes here
  ---
  Import
  Export >

see #28325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants