Editor: Fixed camera name is always 'Camera' when recovering from indexedDB #28309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue: Camera name in viewport camera selector is always 'Camera' (default camera's default name) when recovering from indexedDB, this is a problem when users renamed the default camera; It happens only in a special case that when the scene is empty, since there's no objects in the scene, editor won't dispatch objectChanged nor cameraAdded, while these signals are listened by Viewport.Controls for re-rendering its UI.
The solution: Let Viewport.Controls listens one more signal,
cameraResetted
, dispatched fromeditor.fromJSON()
, then re-render UI oncameraResetted
To reproduce the issue: