Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Tidy up, no substr #28303

Merged
merged 1 commit into from
May 7, 2024
Merged

Editor: Tidy up, no substr #28303

merged 1 commit into from
May 7, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 7, 2024

As title.

A fun fact is that the old code actually takes 1 more char than it needs, but it still work:

property.substr( 1, property.length );  // :D

@Mugen87 Mugen87 added this to the r165 milestone May 7, 2024
@Mugen87 Mugen87 merged commit 65feb79 into mrdoob:dev May 7, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r165
Development

Successfully merging this pull request may close these issues.
2 participants
@ycw @Mugen87