Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Fixed missing unit in background rotation control #28299

Merged
merged 1 commit into from
May 7, 2024
Merged

Editor: Fixed missing unit in background rotation control #28299

merged 1 commit into from
May 7, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 6, 2024 •
edited
Loading

The issue: backgroundRotation control doesn't initialize its value with the supplied unit '°':
not show background rotation unit

This PR fixed that by dispatching an artificial change event right after initializing updating value in setUnit():
show background rotation unit

@mrdoob
Copy link
Owner

mrdoob commented May 6, 2024

I think we should update the text in Number's setUnit() instead.

@mrdoob mrdoob added this to the r165 milestone May 6, 2024
@ycw ycw force-pushed the editor-scene-background-rotation-unit branch from cd36bbd to 0eeb149 Compare May 6, 2024 23:21
@ycw
Copy link
Contributor Author

ycw commented May 6, 2024

done :D

@mrdoob mrdoob merged commit 153cc13 into mrdoob:dev May 7, 2024
7 of 11 checks passed
@ycw ycw deleted the editor-scene-background-rotation-unit branch May 7, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r165
Development

Successfully merging this pull request may close these issues.
2 participants
@ycw @mrdoob