Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyframeTrack: Improve docs and subtype ctors. #28288

Merged
merged 4 commits into from
May 7, 2024

Conversation

trusktr
Copy link
Contributor

@trusktr trusktr commented May 5, 2024

Description

Adds a few small details to docs for KeyframeTrack and its subtypes. Also expresses the lack of interpolation parameters for Boolean and String keyframe tracks in their class constructor.

This contribution is funded by Lume - 3D HTML elements

@trusktr trusktr force-pushed the joe/keyframe-track-docs branch from 8b421ba to 8d1f43d Compare May 5, 2024 18:00
Copy link

github-actions bot commented May 5, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
675.7 kB (167.5 kB) 675.7 kB (167.5 kB) +27 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
454.8 kB (109.8 kB) 454.8 kB (109.8 kB) +0 B

@Mugen87
Copy link
Collaborator

Mugen87 commented May 6, 2024

The unit tests of BooleanKeyframeTrack and StringKeyframeTrack still apply the interpolation to their ctor.

@trusktr
Copy link
Contributor Author

trusktr commented May 7, 2024

e2e snapshot tests failed on the last commit for some reason, but in that last commit I didn't change code, I only removed the unused parts of the unit tests. Seems like a fluke.

I can't get the e2e tests to run locally:

$ npm run test-e2e

> [email protected] test-e2e
> node test/e2e/puppeteer.js

file:///Users/trusktr/src/mrdoob+three.js/node_modules/@puppeteer/browsers/lib/esm/launch.js:301
                reject(new Error([
                       ^

Error: Failed to launch the browser process!


TROUBLESHOOTING: https://pptr.dev/troubleshooting

    at Interface.onClose (file:///Users/trusktr/src/mrdoob+three.js/node_modules/@puppeteer/browsers/lib/esm/launch.js:301:24)
    at Interface.emit (node:events:526:35)
    at Interface.close (node:internal/readline/interface:527:10)
    at Socket.onend (node:internal/readline/interface:253:10)
    at Socket.emit (node:events:526:35)
    at endReadableNT (node:internal/streams/readable:1376:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

Node.js v20.6.1

@Mugen87 Mugen87 added this to the r165 milestone May 7, 2024
@Mugen87 Mugen87 merged commit bff37d7 into mrdoob:dev May 7, 2024
8 of 12 checks passed
@Mugen87 Mugen87 changed the title improve KeyframeTrack and subtype docs KeyframeTrack: Improve docs and subtype ctors. May 7, 2024
@trusktr trusktr deleted the joe/keyframe-track-docs branch May 7, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants