Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Add initRenderTarget(). #28285

Merged
merged 9 commits into from
May 7, 2024
Merged

Conversation

gkjohnson
Copy link
Collaborator

Fix #28282
Based on #28281 which must be merged first

Description

  • Updates initTexture to initialize a WebGLRenderTarget if it has not been already.
  • Updates copyTextureToTexture and copyTextureToTexture3D to support WebGLRenderTarget and initialize it if it has not been already.

This contribution is funded by the Cesium GIS Ecosystem Grant

Copy link

github-actions bot commented May 5, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
678.4 kB (168.1 kB) 678.5 kB (168.1 kB) +97 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.5 kB (110.3 kB) 457.6 kB (110.4 kB) +98 B

@gkjohnson gkjohnson marked this pull request as ready for review May 7, 2024 10:25
@gkjohnson gkjohnson requested a review from Mugen87 May 7, 2024 10:25
@gkjohnson gkjohnson changed the title WebGLRenderer: Update initTexture & copyTextureToTexture to support WebGLRenderTarget WebGLRenderer: Add initRenderTarget function May 7, 2024
@gkjohnson gkjohnson merged commit c3741d2 into mrdoob:dev May 7, 2024
9 of 13 checks passed
@gkjohnson gkjohnson deleted the copy-tex-init branch May 7, 2024 10:51
@Mugen87 Mugen87 changed the title WebGLRenderer: Add initRenderTarget function WebGLRenderer: Add initRenderTarget(). May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGLRenderer: Calling "copyTextureToTexture" on an unused WebGLRenderTarget does nothing
2 participants