Editor: Fixed ghost viewport camera #28277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue: When a non-default active
viewportCamera
is removed, the viewport doesn't update its view:ghost.cam.view.1.mp4
File>New has the same issue, viewport will select ghost camera if previous file's active
viewportCamera
isn't default camera:ghost.cam.view.2.mp4
This PR fixed them all by checking if old
viewportCamera
is gone, then set default camera asviewportCamera
.Preview: https://raw.githack.com/ycw/three.js/editor-viewport-controls-cameras/editor/index.html