Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixed object changes out-of-sync with outliner options #28270

Merged
merged 1 commit into from
May 6, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 3, 2024

fix: #28290

The issue: Outliner doesn't keep in sync with OBJECT (name) and SCRIPT (add/remove):

outsync_.mp4

With this PR, Outliner does keep in sync with those changes ... via re-render the outliner on objectChanged, scriptAdded and scriptRemoved ... Besides that, I also fixed an issue of getScript, it now correctly handles empty array as "no scripts binding to object", s.t. it will not generate in the outliner for no-scripts objects:

insync_.mp4

Preview: https://raw.githack.com/ycw/three.js/tmp-rename/editor/index.html

@Mugen87 Mugen87 added this to the r165 milestone May 6, 2024
@Mugen87 Mugen87 merged commit ac303ab into mrdoob:dev May 6, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: name of object or its material in the scene graph tree does not refresh after changing name in sidebar
2 participants