New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: No pollute Number's prototype #28262

Merged

Mugen87 merged 1 commit into mrdoob:dev from ycw:no-pollute-proto

May 3, 2024

Contributor

ycw commented May 2, 2024

With this PR, number formatting is now easier to reason about:

1/ The fn is now from editor.utils instead of Number's prototype
2/ For grouping, uses Intl module instead of regex


          no pollute prototype

Mugen87 approved these changes

View reviewed changes

Mugen87 added this to the r165 milestone

Mugen87 merged commit a980f81 into mrdoob:dev

7 of 11 checks passed

ycw deleted the no-pollute-proto branch

May 3, 2024 11:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet