Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPUBackend: Remove unnecessary use of GPUAdapter (2) #28217

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 25, 2024

Related issue: #28208

Description

Fix hasFeatureAsync() of #28208 PR.

GPUSupportedFeatures can be found in device and adapter, this PR fix the example of webgpu_loader_gltf_compressed and maintains the original idea of ​​the previous PR #28208.

chirsz-ever and others added 3 commits April 25, 2024 10:01
WebGPUBackend should only need a GPUDevice to
manage resources and check features.
@sunag sunag marked this pull request as ready for review April 25, 2024 13:41
@Mugen87 Mugen87 added this to the r164 milestone Apr 25, 2024
@sunag sunag merged commit 328a460 into mrdoob:dev Apr 25, 2024
11 checks passed
@chirsz-ever
Copy link
Contributor

Maybe the most "correct" way to implement hasFeatureAsync is "waiting until the device is ready". But the current way, requesting the adapter, seems enough to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants