Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: use importmap for app/index.html #28195

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

linbingquan
Copy link
Contributor

@linbingquan linbingquan commented Apr 23, 2024

Related issue: #XXXX

Description

As the title says.

app/index.html has use script type="module", that means the app it requires http service.
The PR should be OK, Correct me if I'm wrong, I will close it.

@linbingquan linbingquan marked this pull request as draft April 23, 2024 02:24
@linbingquan linbingquan marked this pull request as ready for review April 23, 2024 02:42
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 23, 2024

For testing: https://rawcdn.githack.com/linbingquan/three.js/dev-editor-app/editor/index.html

A published app works as before (assuming it is hosted on a web sever) so the PR is fine.

I guess we have to move to import maps if we want to include addons in published apps which is required for area light or text geometry.

@linbingquan
Copy link
Contributor Author

I guess we have to move to import maps if we want to include addons in published apps which would is required for area light or text geometry.

Yeah, you're right. That's exactly what I was thinking.

@Mugen87 Mugen87 added this to the r164 milestone Apr 23, 2024
@mrdoob mrdoob merged commit 7376a8d into mrdoob:dev Apr 23, 2024
11 checks passed
@linbingquan linbingquan deleted the dev-editor-app branch April 25, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants