-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Add transition effect. #28174
Conversation
For testing: https://rawcdn.githack.com/linbingquan/three.js/dev-transition/examples/webgl_postprocessing_crossfade.html With this refactoring the FPS falls into the 40-50 FPS range during the transition. With the existing version on |
remove useless code
Thank you for your test. I repeated the same situation on my laptop. TBH, my laptop is not high performance, only has 30FPS. The difference in values is not significant. I checked the code, I found unnecessary I tested them locally and the FPS values were close, but I am not sure it will solve the problem. |
The latest version seems to be fixed 👍 . |
Should we rename |
Sounds good to me! |
Let me to do it. |
@linbingquan It seems the effect is broken after the first transition, see https://threejs.org/examples/webgl_postprocessing_transition. Do you mind having a look? |
This is actually a regression of #28391 since |
Related issue: #XXXX
Description
refactor
Transition
toRenderTransitionPass.js
.If this PR has any problem, please tell me.