Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileLoader: Evaluate X-File-Size header before Content-Length. #28169

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 20, 2024

Closes #23896.

Description

This makes sure devs can use X-File-Size to report the uncompressed content length of compressed assets. If X-File-Size isn't set, Content-Length will be used as before.

Using this approach makes #23896 obsolete so there is no need to expose the response object in a custom progress event.

@Mugen87 Mugen87 added this to the r164 milestone Apr 20, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
674.4 kB (167.2 kB) 674.4 kB (167.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
453.8 kB (109.6 kB) 453.8 kB (109.6 kB) +0 B

@Mugen87 Mugen87 merged commit c817054 into mrdoob:dev Apr 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant