Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRMLLoader: Make sure rotation axis is normalized. #28162

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

vorth
Copy link
Contributor

@vorth vorth commented Apr 19, 2024

Description

Three.js AxisAngle apparently requires a normalized axis vector. VRML may also, but I had many files (converted from VRML 1.0) that contained un-normalized axis vectors.

Whether there is a defect in my VRML data or not, normalization is idempotent and can only help.

VRML files can contain non-normalized rotation vectors, whether correctly or incorrectly.  This change loads such files safely, and has no impact if the vector is already normalized.
@Mugen87 Mugen87 changed the title Fixing rotation defect in VRMLLoader.js VRMLLoader: Make sure rotation axis is normalized. Apr 19, 2024
@Mugen87 Mugen87 added this to the r164 milestone Apr 19, 2024
@Mugen87 Mugen87 merged commit 7ce0c40 into mrdoob:dev Apr 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants