Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: Line2NodeMaterial - simplify extension #28160

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

aardgoose
Copy link
Contributor

Delay the call to setupShaders() to setup() phase, to allow easier and more efficient subclassing (removes requirement for subclass making a redundant call to setupShaders()).

@sunag sunag added this to the r164 milestone Apr 19, 2024
@sunag sunag merged commit ec498d0 into mrdoob:dev Apr 19, 2024
11 checks passed
@aardgoose aardgoose deleted the line2node-fix branch April 22, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants