Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: copyTextureToTexture3D depth fix and exclusive approach #28154

Merged

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Apr 18, 2024

Related issue: #27771

Description
Use exclusive approach on copyTextureToTexture3D to avoid off-by-one errors and align depth calculation to width and height.

This contribution is funded by Utsubo

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
674.4 kB (167.2 kB) 674.4 kB (167.1 kB) -26 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
453.9 kB (109.6 kB) 453.8 kB (109.6 kB) -26 B

@Mugen87 Mugen87 added this to the r164 milestone Apr 18, 2024
@Mugen87 Mugen87 merged commit 3ecc744 into mrdoob:dev Apr 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants