MeshPhysicalMaterial: Add dispersion.
#28051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
donmccurdy
reviewed
Apr 2, 2024
This was referenced Apr 3, 2024
Merged
|
@mrdoob The CI always fails with my version of the E2E screenshot for the new example |
|
Never mind! I could fix the issue by generating the screenshot on a different device, see #28062. |
|
The effect here looks excellent, thank you @Mugen87!! |
This was referenced Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #28001.
Description
This PR adds dispersion support to
MeshPhysicalMaterialbased on KHR_materials_dispersion.It enhances
GLTFLoader, the editor and adds a new examplewebgl_loader_gltf_dispersion. I have temporarily updated the build files so it can be tested here:https://rawcdn.githack.com/Mugen87/three.js/55c6ae017d7953a4040d8fdbe00fbb7f9cd31c49/examples/webgl_loader_gltf_dispersion.html
For comparison this is the same model with the Khronos glTF Sample Viewer: https://github.khronos.org/glTF-Sample-Viewer-Release/?model=https://raw.GithubUserContent.com/KhronosGroup/glTF-Sample-Assets/main/./Models/DispersionTest/glTF-Binary/DispersionTest.glb
The idea is to use the dispersion value to compute three separate IOR values for the red, green, and blue channel. The transmission computation is then evaluated per color channel with the respective IOR. The implementation is based on the glTF sample viewer GLSL.
I'll update the docs when the implementation is approved.