USDZExporter: Rename parse to parseAsync #28049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USDZExporter: Add parse method Examples: Update misc_exporter_usdz Editor: Replace USDZExporter.parse with parseAsync
Mugen87
reviewed
Apr 2, 2024
Mugen87
approved these changes
Apr 2, 2024
This was referenced Apr 21, 2024
|
FYI @elalish |
aardvarkk
added a commit
to aardvarkk/model-viewer
that referenced
this pull request
May 21, 2024
elalish
pushed a commit
to google/model-viewer
that referenced
this pull request
May 29, 2024
* Upgrade to latest threejs (r164) * `parse` was renamed to `parseAsync` - mrdoob/three.js#28049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28050
Description
Adjust naming consistency for USDZExporter