Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Rename .setReference() -> .updateReference() and use reference in renderMap/frameMap #28010

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Mar 27, 2024

Description

I believe the name better represents the purpose, this also corrects duplicate event calls when used in the same references.

@sunag sunag marked this pull request as ready for review March 27, 2024 07:18
@sunag sunag added this to the r163 milestone Mar 27, 2024
@sunag sunag merged commit 66f7aa8 into mrdoob:dev Mar 27, 2024
11 checks passed
@sunag sunag deleted the dev-reference branch April 4, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant